mcMMO treefeller code review

Official forum for BetaWorld 2.0 minecraft server. Website: https://www.betaworld.xyz
Post Reply
User avatar
Julius
Site Admin
Posts: 504
Joined: 27.7.2019 00:07:29
Location: Finland
Contact:

mcMMO treefeller code review

Post by Julius » 1.10.2025 19:10:26

So this is just one example of bad mcMMO code we have to deal here.
So here is the original code that had error of dropping incorrect type of LOG when their data was different than block breaked.
mcmmo original part 1.JPG
(90.63 KiB) Not downloaded yet
And here is how i fixed it:
mcmmo new part 1.JPG
(74.27 KiB) Not downloaded yet
Well thats not all...
There was that BAD sub function that had another sub function witch handled adding blocks to the treefeller list, just take a look:
mcmmo original part 2.JPG
(57.82 KiB) Not downloaded yet
mcmmo original part 3.JPG
(71.56 KiB) Not downloaded yet
Yeah.. well reprogrammed that function and now it looks like this (and yes this includes both of the images above):
mcmmo new part 2.JPG
(73.94 KiB) Not downloaded yet
Image
Paypal link above is no longer in use. Jabber/XMPP: [email protected]
My public PGP key: viewtopic.php?t=177&start=1 Email address: [email protected]

Post Reply